Reviewing merge request #3: Fix compilation when Qt is built with -no-stl.

There's no need to go through std::string for simple
strings. QByteArray is more than reasonable.

This is also a performance improvement, considering toStdString()
calls toAscii(), which could be much slower than the Latin-1 codec
(toAscii() uses the codec set with QTextCodec::setCodecForCStrings).

Requested by: Thiago Macieira
Status: Open
Source repository: thiagos-contextkit:compile-qt-nostl
Target repository: contextkit:master
Created at: January 14th, 2010 14:18

Commits that would be merged:

Version 1

Version 1

ae656f5
ede1174

Fix compilation when Qt is built with -no-stl.

Showing

Showing ae656f5-ede1174

Comments
Include comments entered inline

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository

One way to merge in these changes is to pull them into a local branch for review, verifying the changes and then merge to back to master.

# Check out a new branch for integration
git checkout -b merge-requests/3

# Fetch the merge request into this branch
git pull \
  git://gitorious.org/maemo-af/contextkit.git \
  refs/merge-requests/3

# Show the commits, assess they are okay
git log --pretty=oneline --abbrev-commit master..merge-requests/3

# To apply the changes to your branch:
git checkout master
git merge merge-requests/3
git push origin master

Reviewing merge request #3: Fix compilation when Qt is built with -no-stl.

Commits that would be merged:

Comments Include comments entered inline

Add a new comment:

Gitorious

Comments
Include comments entered inline